-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows to have SVG URL #4993
Allows to have SVG URL #4993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I then test it in ngeo using "make serve-gmf-apps", I get this:
GET https://localhost:3000/contribs/gmf/apps/image/crosshair.svg?url 404 (Not Found)
So it's not really webpack, that's resolving the path, the browser itself does it. In a proper GMF installation, thanks to the URL-rewriting, you can access the same interface with different URL. I think there is no way around an absolute path, preferably coming from the python part.
Yes It's also possible to use the python URL resolver with the following config: For me booth should work... |
I just fixed the issue :-) |
Using this branch, I used No crosshair for me. The browser requests this:
This is |
Do you use the latest version? |
Yes, I just tried again. Now it is just a 404 |
:-) |
89ecf05
to
e711d79
Compare
Fill also fix: #4940 |
70d9352
to
e860e82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would rather avoid using SVGs than to have this SVG loader.
I added some small comments, otherwise LGTM.
buildtools/generate.js
Outdated
@@ -0,0 +1,98 @@ | |||
// Initially get from https://github.com/tildeio/simple-html-tokenizer/blob/v0.1.1/lib/simple-html-tokenizer/generator.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give a clearer filename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like generate-html-from-tockens.js
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate-xml-from-tokens.js
Add an SVG to permalik crosshair Add an included logo Remove no more existing Add example
Test URL: https://camptocamp.github.io/ngeo/svg-url/examples/contribs/gmf/apps/desktop_alt.html?map_crosshair=true
https://camptocamp.github.io/ngeo/svg-url/examples/svg.html