Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check cors manually to track cors issues #5016

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Check cors manually to track cors issues #5016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions buildtools/check-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function loaded(page, browser) {
}, 500);
}
(async () => {
const browser = await puppeteer.launch();
const browser = await puppeteer.launch({args: ['--disable-web-security']});
const page = await browser.newPage();
await page.setViewport({width: 1920, height: 1080});
await page.setRequestInterception(true);
Expand All @@ -86,7 +86,12 @@ function loaded(page, browser) {
url.startsWith('https://geomapfish-demo-2-5.camptocamp.com/') ||
url.startsWith('https://wms.geo.admin.ch/')) {
requestsURL.add(url);
request.continue();
if (url.startsWith('https://geomapfish-demo-2-5.camptocamp.com/')) {
request.headers().origin = 'http://localhost:3000';
}
request.continue({
headers: request.headers()
});
} else if (url.includes('tile.openstreetmap.org')) {
request.respond({
status: 200,
Expand All @@ -99,20 +104,36 @@ function loaded(page, browser) {
request.abort();
}
});
page.on('requestfinished', request => {
page.on('requestfinished', async (request) => {
const url = request.url();
requestsURL.delete(url);
loaded(page, browser);
if (url.startsWith('https://geomapfish-demo-2-5.camptocamp.com/') &&
request.headers()['sec-fetch-mode'] == 'cors' &&
request.response().headers()['access-control-allow-origin'] == undefined) {
console.log(`CORS error on: ${url}`);
console.log("= Request headers");
for (const n in request.headers()) {
console.log(`${n}: ${request.headers()[n]}`);
}
console.log("= Response headers");
for (const n in request.response().headers()) {
console.log(`${n}: ${request.response().headers()[n]}`);
}
if (request.response().headers()['content-type'] == 'text/html') {
const text = await response.text();
console.log('= Response body');
console.log(text);
}
process.exit(2);
}
});
page.on('requestfailed', request => {
const url = request.url();
if (url.startsWith('http://localhost:3000/') ||
url.startsWith('https://geomapfish-demo-2-5.camptocamp.com/') ||
url.startsWith('https://wms.geo.admin.ch/')) {
console.log(`Request failed on: ${url}`);
for (const n in request.response().headers()) {
console.log(`${n}: ${request.response().headers()[n]}`);
}
process.exit(2);
}
loaded(page, browser);
Expand Down