Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mapswipe component and example #5059

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Conversation

RBcote
Copy link
Contributor

@RBcote RBcote commented Aug 13, 2019

This patch shows map swipe example. Swipe input value is set to 50, so Open sea map is set on half on the map. Swiping to the right show full the layer on the map.

@RBcote RBcote requested a review from adube August 13, 2019 12:54
@RBcote RBcote changed the title 1029(2) Map swipe example done 1029(2) Introduce mapswipe component and example Aug 13, 2019
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please, address these minor changes.

examples/mapswipe.js Outdated Show resolved Hide resolved
examples/mapswipe.js Outdated Show resolved Hide resolved
examples/mapswipe.html Outdated Show resolved Hide resolved
src/map/swipe.html Outdated Show resolved Hide resolved
src/map/swipe.js Outdated Show resolved Hide resolved
src/map/swipe.js Outdated Show resolved Hide resolved
src/map/swipe.js Outdated Show resolved Hide resolved
src/map/swipe.js Show resolved Hide resolved
src/map/swipe.js Outdated Show resolved Hide resolved
@RBcote RBcote changed the title 1029(2) Introduce mapswipe component and example 1029 Introduce mapswipe component and example Aug 13, 2019
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Here's some more minor changes.

src/map/swipe.js Show resolved Hide resolved
src/map/swipe.js Outdated Show resolved Hide resolved
src/map/swipe.js Outdated Show resolved Hide resolved
src/map/swipe.js Show resolved Hide resolved
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for me. I'll assign Fred as reviewer for him to do the official review.

@adube adube requested a review from fredj August 13, 2019 15:22
src/map/swipe.js Outdated Show resolved Hide resolved
@adube
Copy link
Contributor

adube commented Aug 19, 2019

@fredj Would you please take a look at this patch and see if we can merge it?

@adube adube requested review from sbrunner and removed request for fredj August 21, 2019 12:38
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @fredj will also have a look :-)

src/map/swipe.js Show resolved Hide resolved
examples/mapswipe.css Outdated Show resolved Hide resolved
@adube adube changed the title 1029 Introduce mapswipe component and example Introduce mapswipe component and example Aug 23, 2019
@adube
Copy link
Contributor

adube commented Aug 23, 2019

@fredj Build failed, but I'm not sure it is relevant to the code here... Would you please check?

src/map/swipe.js Outdated Show resolved Hide resolved
@fredj fredj self-assigned this Aug 26, 2019
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

@RBcote RBcote merged commit ab58167 into master Aug 27, 2019
@sbrunner sbrunner added this to the 2.5 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants