-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve snapping #5084
Improve snapping #5084
Conversation
844ae79
to
8d51078
Compare
Note that this works perfectly now, so we might merge this and consider layertree refactoring later. |
6060766
to
d95e91f
Compare
d95e91f
to
7353704
Compare
e2bc11a
to
e9000e8
Compare
On the example it seem that the activation and the deactivation don't work... |
e9000e8
to
89c0d84
Compare
Yes, fixed, hope everything is good now. |
+1 Thanks, @fredj can you have a second look? |
@fredj : This PR is ready for merge, do you want to have a look before ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
https://jira.camptocamp.com/browse/GSGMF-1035
Test link : https://camptocamp.github.io/ngeo/gsgmf-1035-improve_snapping/examples/contribs/gmf/apps/desktop_alt.html?dim_FLOOR=*&lang=fr&tree_groups=Edit%2CSnapping%2CSnapping%20tollerance%2CSnapping%20no%20edge%2CSnapping%20no%20vertex&baselayer_ref=OSM%20map&baselayer_opacity=100&tree_group_layers_Snapping%20tollerance=Snapping%20tollerance%2Cpoint%20snap%20tolerance%2Cline%20snap%20tolerance%2Cpolygon%20snap%20tolerance
Activate or deactivate snapping on some layers and give a try to "Draw and measure".