-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new query component and example #5114
Conversation
@sbrunner Would you please give me hits how to fix these issues:
|
@adube I've pushed a commit that should fix the typing checks |
24959fc
to
f8c6f39
Compare
the travis error is not related to your changes. I've restarted the build |
@adube The CI pass :-) |
Alright! This is ready for review, then. |
f8c6f39
to
574cd08
Compare
@fredj I'll take care of moving the "autoclear" option of the component to the This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good, thanks
GSGMF 1047 - phase 1
This patch is the first step towards implementing a new way to query the map by drawing polygons.
This patch introduces:
QueryModeSelector
service that:QueryKeyboard
service<ngeo-query>
component that:<ngeo-map-query>
and<ngeo-bbox-query>
directivesLimit option
There is a
limit
option that can be set in thengeoQueryOptions
angular value.There is also a
ngeo-bbox-query-limit
attribute that can be set in the `ngeo-bbox-query.As part of this refactoring, I suggest that only the
limit
option inngeoQueryOptions
should be used.autoclear option
There is a
ngeo-map-query-autoclear
attribute that can be set in thengeo-map-query
directive. It was added as a possible "binding attribute" in the new component.I'm mentionning it, because we do have
ngeoQueryOptions
and it could go there instead. If you think the option should go there instead, please let me know.Update: it was decided that the autoclear option should go in the
ngeoQueryOptions
instead. This will come in an other PR.Next step
The next step will be to remove the 2 old directives, examples and replace the query tool in all examples (ngeo, gmf) and applications (gmf).