Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the query panel component #5120

Merged
merged 5 commits into from
Sep 25, 2019

Conversation

adube
Copy link
Contributor

@adube adube commented Sep 16, 2019

GSGMF 1047 - phase 3

This patch is the third step towards implementing a new way to query the map by drawing polygons.

This patch introduces a new <ngeo-query-panel> component that is bound to the QueryModeSelector service and allows to change query query mode and action.

The panel is added:

  • in the ngeo query example
  • in both desktop and desktop_alt applications

SVG icons

The SVG icons used in the query panel component were copied from those that are in contribs/gmf/src/icons into src/icons.

Icon in the apps

The icon in the apps (in the right toolbar) is currently fa-info. I didn't find the icon that looks like a slighly rotated square with round vertice.

@adube adube force-pushed the gsgmf-1047-3-query-panel branch 2 times, most recently from d67a393 to 2aee217 Compare September 17, 2019 14:38
@sbrunner sbrunner changed the title WIP Introduce the query panel component [WIP] Introduce the query panel component Sep 17, 2019
@adube adube force-pushed the gsgmf-1047-3-query-panel branch 2 times, most recently from 191bb44 to 6841fd7 Compare September 18, 2019 13:22
@adube adube changed the title [WIP] Introduce the query panel component Introduce the query panel component Sep 18, 2019
@adube adube requested a review from fredj September 18, 2019 13:28
@adube
Copy link
Contributor Author

adube commented Sep 18, 2019

@fredj Ready for review.

@sbrunner What is the font-awesome name for this icon?

Query_selection_panel_fa

@sbrunner sbrunner added this to the 2.5 milestone Sep 18, 2019
@adube
Copy link
Contributor Author

adube commented Sep 18, 2019

@sbrunner Any idea how to fix this issue?

src/query/panelComponent.js(22,15): error TS2307: Cannot find module './panelComponent.html'.
3088The command "! (npm run typecheck|grep -v '^node_modules/'|grep '^[a-z]')" exited with 1

@adube
Copy link
Contributor Author

adube commented Sep 18, 2019

@sbrunner Any idea how to fix this issue?

src/query/panelComponent.js(22,15): error TS2307: Cannot find module './panelComponent.html'.
3088The command "! (npm run typecheck|grep -v '^node_modules/'|grep '^[a-z]')" exited with 1

I think I got it...

@adube adube force-pushed the gsgmf-1047-3-query-panel branch 2 times, most recently from 40e752e to d704b53 Compare September 18, 2019 15:38
@adube
Copy link
Contributor Author

adube commented Sep 18, 2019

@fredj Travis is often complaining about things unrelated to the commits I make. When that happens, I do: git commit --amend and hope for the best.

Is there a quicker way to do that?

@adube
Copy link
Contributor Author

adube commented Sep 18, 2019

@fredj Travis passes! Ready for review.

@adube adube force-pushed the gsgmf-1047-3-query-panel branch 2 times, most recently from 352619e to 672122e Compare September 19, 2019 17:30
@adube
Copy link
Contributor Author

adube commented Sep 19, 2019

Okay, I'm loosing patience with Travis. Would someone please help me figure out why it is always failing now? It was fine yesterday.

@sbrunner sbrunner closed this Sep 20, 2019
@sbrunner sbrunner reopened this Sep 20, 2019
@sbrunner
Copy link
Member

I think that your pull request should be rebsed ...

@adube
Copy link
Contributor Author

adube commented Sep 20, 2019

Rebased.

@adube
Copy link
Contributor Author

adube commented Sep 20, 2019

@fredj Ready for review.

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adube ; I've pushed a very small cosmetic update in 82405f4

@adube
Copy link
Contributor Author

adube commented Sep 25, 2019

Thanks for the review.

@adube adube merged commit 956225e into camptocamp:master Sep 25, 2019
@adube adube deleted the gsgmf-1047-3-query-panel branch September 25, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants