-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press escape to desactivate drawing in edition #5129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Sep 19, 2019
fredj
reviewed
Sep 19, 2019
llienher
force-pushed
the
GSEPF-259_escape-cancelation-draw
branch
from
September 20, 2019 06:50
3759f05
to
738fb6e
Compare
gberaudo
reviewed
Sep 20, 2019
gberaudo
reviewed
Sep 20, 2019
llienher
force-pushed
the
GSEPF-259_escape-cancelation-draw
branch
2 times, most recently
from
September 23, 2019 09:27
37826bb
to
d70e102
Compare
llienher
force-pushed
the
GSEPF-259_escape-cancelation-draw
branch
from
September 23, 2019 09:48
d70e102
to
25d50f4
Compare
gberaudo
reviewed
Sep 23, 2019
gberaudo
reviewed
Sep 23, 2019
gberaudo
reviewed
Sep 23, 2019
gberaudo
reviewed
Sep 23, 2019
gberaudo
reviewed
Sep 23, 2019
gberaudo
reviewed
Sep 23, 2019
llienher
force-pushed
the
GSEPF-259_escape-cancelation-draw
branch
from
September 23, 2019 15:07
f91e575
to
72fc345
Compare
gberaudo
approved these changes
Sep 23, 2019
Is it relay without risque to merge it on a stable branch? |
@sbrunner, this is a new functionality that triggers only when the "esc" key is pressed. |
Should be merged on 2.4 and master :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.camptocamp.com/browse/GSEPF-259