Do not copy 'visible' property for WMTS layers #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
changed the title
sbrunner
reviewed
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WMTS layers are created in a way that their properties get asynchronously set, i.e. after WMTS capabilities are obtained.
The setting of the layer's initial visibility can be done before that, which can result in an issue of overriding the visibility after the capabilities are read, i.e. the created layer while reading the capabilities has its visible property set to true, but the original one may have its visible property to false.
To fix this issue, an utility method was added in the LayerHelper of ngeo to be able to exclude the keys we know we don't want to copy.