Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close button on password change modal #5522

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix close button on password change modal #5522

merged 1 commit into from
Feb 13, 2020

Conversation

llienher
Copy link
Member

@llienher llienher self-assigned this Feb 13, 2020
github-actions[bot]
github-actions bot reviewed Feb 13, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples: https://camptocamp.github.io/ngeo/GSGMF-1214_lost-password-modal-fix/examples/
API documentation: https://camptocamp.github.io/ngeo/GSGMF-1214_lost-password-modal-fix/apidoc/

sbrunner
sbrunner approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@llienher llienher merged commit 169c76f into master Feb 13, 2020
@llienher llienher deleted the GSGMF-1214_lost-password-modal-fix branch February 13, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sbrunner sbrunner sbrunner approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llienher @sbrunner