Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default layout for print component #5620

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Set default layout for print component #5620

merged 3 commits into from
Mar 23, 2020

Conversation

svaabs
Copy link
Contributor

@svaabs svaabs commented Mar 17, 2020

The aim of this change is to allow the configuration of the default print layout in the print component.

@sbrunner
Copy link
Member

@svaabs Can't it be in the 'gmfPrintOptions'?

@svaabs
Copy link
Contributor Author

svaabs commented Mar 17, 2020

@svaabs Can't it be in the 'gmfPrintOptions'?

@sbrunner Sure, if that is the prefered way, I will change the code.

llienher
llienher approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@llienher llienher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sbrunner
Copy link
Member

@svaabs your tow pull request will be in conflict...

@sbrunner sbrunner merged commit 14d3237 into camptocamp:2.4 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@llienher llienher llienher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svaabs @sbrunner @llienher