Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply transparency on search color #5649

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

svaabs
Copy link
Contributor

@svaabs svaabs commented Mar 25, 2020

With this changes we make sure that the transparency of the default style is applied to new colors set by the colorpicker.

@svaabs
Copy link
Contributor Author

svaabs commented Mar 25, 2020

@sbrunner I scrolled through the travis log but I am not sure where to find the relevant error. Can you help me?

@sbrunner
Copy link
Member

@svaabs You should be able to restart the build...

@svaabs
Copy link
Contributor Author

svaabs commented Mar 26, 2020

@sbrunner I am afraid I am not authorized to restart the build or at least I do not know how to.

@sbrunner
Copy link
Member

Me neither, Then amend the last commit without any modification, and push it again...

@svaabs
Copy link
Contributor Author

svaabs commented Mar 31, 2020

As discussed with @pfirpfel I will add some more information to reproduce the changes.

Steps:

Result (current ngeo solution):

  • New color is applied
  • No transparency on the outline
  • Transparency of the fill style set to 0.5

Expected result (with this pull request):

  • New color is applied
  • Outline uses the transparency of the default style (some transparency)
  • Fill style uses the transparency of the default style (full transparency)

@sbrunner sbrunner requested a review from fredj March 31, 2020 11:05
@sbrunner
Copy link
Member

@fredj does it look good to you?

Copy link
Contributor

@pfirpfel pfirpfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the change locally. As far as I can see, the default geomapfish behaviour does not visually change.

The change looks good in my opinion.

@fredj
Copy link
Member

fredj commented Apr 14, 2020

looks good to me too

@sbrunner sbrunner merged commit 5fca23a into camptocamp:2.4 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants