-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port default print layout #5661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbrunner I have an issue in the console, testing this port:
Do you have an idea what is missing ? I'm pretty sure we already had this problem in the past but cannot figure out what we did to fix it... |
@llienher Where do you found that? |
@sbrunner It's in my console, error when trying to print |
It's not already present on master? |
Yes, it is actually the previous merged PR that broke that, not related to this one. So visible on master. |
C'est aussi le cas sur 2.4 :-( |
This line looks wrong: https://github.com/camptocamp/ngeo/pull/5621/files#diff-253425453dea4e54ec1f5fde0c68b1d5R1000 |
@sbrunner Nice catch, seems to fix it if we remove it. |
But now this line will not work... |
8118945
to
ae4998b
Compare
ae4998b
to
c0cdd4f
Compare
@sbrunner I did pass the parameter to the service from the component via an optional parameter in the createSpec method. That's cleaner. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
c0cdd4f
to
f6f4f89
Compare
Error on backporting to branch 2.4, error on cherry picking ['116ad94d1ee8133889ce0c26e68cb7de65d04cf3', 'cf7ac12f699c8717ea7cf29be7fb26250bbaff74', 'f6f4f899297b7cbe749dced281118949e35ecc74']: to continue do: And do the pull request (if needed). |
Port 2.4 features in master branch