Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] partner_title_order: Migration to 18.0 #5

Closed
wants to merge 11 commits into from
Closed

[18.0][MIG] partner_title_order: Migration to 18.0 #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5b394ef
[ADD] partner_title_order
simahawk Oct 21, 2021
ef4299d
[UPD] Update partner_title_order.pot
oca-travis Nov 2, 2021
93e6a34
[UPD] README.rst
OCA-git-bot Nov 2, 2021
8d13f10
[ADD] icon.png
OCA-git-bot Nov 2, 2021
c4e79b8
Added translation using Weblate (French)
klodr Sep 18, 2022
b5e7e17
Translated using Weblate (French)
klodr Jun 4, 2023
2cb1b5f
[UPD] README.rst
OCA-git-bot Sep 3, 2023
44945e8
Added translation using Weblate (Spanish)
Ivorra78 Jan 13, 2024
e1183db
Translated using Weblate (Spanish)
Ivorra78 Jan 13, 2024
ee2fe69
[IMP] partner_title_order: pre-commit auto fixes
Kimkhoi3010 Oct 2, 2024
7548f50
[MIG] partner_title_order: Migration to 18.0
Kimkhoi3010 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions partner_title_order/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ Contributors
- `Trobz <https://trobz.com>`__:

- Khoi Vo <[email protected]>
- Khoi (Kien Kim) <[email protected]>

Other credits
-------------
Expand All @@ -70,6 +71,11 @@ Other credits
- Cosanum
- Camptocamp R&D

The migration of this module from 17.0 to 18.0 was financially supported
by:

- Camptocamp.

Maintainers
-----------

Expand Down
2 changes: 1 addition & 1 deletion partner_title_order/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"name": "Partner title order",
"summary": "Makes partner title sortable by sequence",
"version": "14.0.1.0.0",
"version": "18.0.1.0.0",
"category": "Hidden",
"author": "Camptocamp, Odoo Community Association (OCA)",
"license": "AGPL-3",
Expand Down
3 changes: 2 additions & 1 deletion partner_title_order/readme/CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
- Simone Orsi \<<[email protected]>\>

- [Trobz](https://trobz.com):
- [Trobz](https://trobz.com):
- Khoi Vo \<<[email protected]>\>
- Khoi (Kien Kim) \<<[email protected]>\>
4 changes: 4 additions & 0 deletions partner_title_order/readme/CREDITS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@

- Cosanum
- Camptocamp R&D

The migration of this module from 17.0 to 18.0 was financially supported by:

- Camptocamp.
6 changes: 6 additions & 0 deletions partner_title_order/static/description/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
<li>Simone Orsi &lt;<a class="reference external" href="mailto:simone.orsi&#64;camptocamp.com">simone.orsi&#64;camptocamp.com</a>&gt;</li>
<li><a class="reference external" href="https://trobz.com">Trobz</a>:<ul>
<li>Khoi Vo &lt;<a class="reference external" href="mailto:khoivha&#64;trobz.com">khoivha&#64;trobz.com</a>&gt;</li>
<li>Khoi (Kien Kim) &lt;<a class="reference external" href="mailto:khoikk&#64;trobz.com">khoikk&#64;trobz.com</a>&gt;</li>
</ul>
</li>
</ul>
Expand All @@ -417,6 +418,11 @@ <h2><a class="toc-backref" href="#toc-entry-5">Other credits</a></h2>
<li>Cosanum</li>
<li>Camptocamp R&amp;D</li>
</ul>
<p>The migration of this module from 17.0 to 18.0 was financially supported
by:</p>
<ul class="simple">
<li>Camptocamp.</li>
</ul>
</div>
<div class="section" id="maintainers">
<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
Expand Down
6 changes: 3 additions & 3 deletions partner_title_order/tests/test_partner_title.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Copyright 2020 Camptocamp SA
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)

from odoo.tests.common import SavepointCase
import odoo.tests.common as common


class TestPartnerTitle(SavepointCase):
class TestPartnerTitle(common.TransactionCase):
@classmethod
def setUpClass(cls):
super().setUpClass()
Expand All @@ -14,7 +14,7 @@ def test_default_order(self):
partner_titles = self.env["res.partner.title"].search([])
self.assertEqual(
partner_titles.mapped("name"),
partner_titles.sorted(lambda x: x.name).mapped("name"),
Copy link
Member

@TDu TDu Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change because the test failed ?
Because it should not have, all sequence fields should have been set to 10 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

partner_titles.sorted(lambda x: (x.sequence, x.name)).mapped("name"),
)

def test_sequence_order(self):
Expand Down
Loading