Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSREN3D-161: Station Primitives & Arcs #60

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bkuster
Copy link
Contributor

@bkuster bkuster commented Nov 28, 2022

JIRA issue

GSREN3D-161

Description

  • Updated: @vcmap/core
  • Fix: Properly destroys created VcsApps on unMounted
  • Adds Disk rendering of stations. This is still a prototype
  • Adds a Station model & store.
  • Adds a Station selection.
  • Adds filterting for station POIs. Note: this does not work, since I cant find a reasonable join key. id_station and station.id do not
    overlap reasonably.

@bkuster
Copy link
Contributor Author

bkuster commented Nov 28, 2022

so, the export const enum is a bug on hour end, I have created an issue and am hoping to get it resolved fast. but how to fix the inability to index using a symbol is too deep down the TS rabbit hole for me. @ismailsunni any ideas?

@bkuster
Copy link
Contributor Author

bkuster commented Nov 29, 2022

pointing to our main branch in package.json, this now compiles & works

@@ -29,7 +29,7 @@
"dependencies": {
"@heroicons/vue": "^2.0.11",
"@pinia/testing": "^0.0.14",
"@vcmap/core": "^5.0.0-rc.23",
"@vcmap/core": "git://[email protected]/virtualcitySYSTEMS/map-core.git",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publish before merging

@ismailsunni
Copy link
Member

hi @bkuster regarding the POI and station layer, it will have a field connecting POI and station in the POI table. It's coming :)

@ismailsunni
Copy link
Member

hi @bkuster
I saw there is a new tag on the VC map core (https://github.com/virtualcitySYSTEMS/map-core/releases/tag/v5.0.0-rc.24). Does it contain the features that we need here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants