Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume hierarchies are stored in vars -- call deref instead of var-get #52

Closed
camsaul opened this issue Jun 4, 2021 · 2 comments
Closed

Don't assume hierarchies are stored in vars -- call deref instead of var-get #52

camsaul opened this issue Jun 4, 2021 · 2 comments
Labels
clojurescript support Issues that we have to tackle in order to get ClojureScript support working. good first issue Good for newcomers
Milestone
0.12.1

Comments

@camsaul
Copy link
Owner

camsaul commented Jun 4, 2021

The various dispatchers resolve their hierarchies by calling var-get. Vanilla multifns just call deref, so the hierarchy works whether it's a Var or Atom or Delay or whatever.

ClojureScript doesn't have var-get, so that's another reason to make this change.
@camsaul camsaul added the clojurescript support Issues that we have to tackle in order to get ClojureScript support working. label Jun 4, 2021
@camsaul camsaul mentioned this issue Jun 4, 2021
Open
@camsaul camsaul added the good first issue Good for newcomers label Jun 11, 2021
eoliphan added a commit to eoliphan/methodical that referenced this issue Jul 25, 2021
@eoliphan
replaced var-get's with deref, fix for camsaul#52
20785d0
eoliphan added a commit to eoliphan/methodical that referenced this issue Jul 25, 2021
@eoliphan
replaced var-get's with deref, fix for camsaul#52
71fce71
@eoliphan eoliphan mentioned this issue Jul 25, 2021
Merged
camsaul pushed a commit that referenced this issue Aug 20, 2021
@eoliphan
var-get -> deref usage (#77)
da21020 
* replaced var-get's with deref, fix for #52

* replaced var-get's with deref, fix for #52
@camsaul
Copy link
Owner Author

camsaul commented Aug 20, 2021

Fixed by #77

@camsaul camsaul closed this as completed Aug 20, 2021
@camsaul camsaul added this to the 0.12.1 milestone Aug 20, 2021
@camsaul
Copy link
Owner Author

camsaul commented Apr 7, 2022

This is actually still an issue because defmulti asserts that a :hierarchy is a var

@camsaul camsaul reopened this Apr 7, 2022
@camsaul camsaul modified the milestones: 0.12.1, 0.12.3 Apr 7, 2022
@camsaul camsaul closed this as completed Apr 7, 2022
@camsaul camsaul mentioned this issue Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clojurescript support Issues that we have to tackle in order to get ClojureScript support working. good first issue Good for newcomers
Projects
None yet
Milestone
0.12.1
Development

No branches or pull requests
1 participant
@camsaul