Consider all primary methods when calculating effective dispatch value #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this case:
:toucan
isa:can
:toucan
isa:bird
:bird
over:can
:can
:bird
If you invoke the multimethod with dispatch value
:bird
, it will use the:bird
primary method with nonext-method
.If you invoke the multimethod with dispatch value
:toucan
, it will use the:bird
primary method with the:can
primary method as thenext-method
.Thus even though dispatch values
:bird
and:toucan
both use the:bird
primary method, their effective dispatch values are not the same; because invoking the method with dispatch value:bird
and with dispatch value:toucan
is not the same thing.We need to consider all matching dispatch values when calculating effective dispatch values.
This PR fixes the bug above