Fix insert transform only keys in first row #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnkhuat
commented
Mar 27, 2023
| v))))) | ||
| row-xform (apply comp row-xforms)] | ||
| (map row-xform rows))) | ||
| (let [x-forms (for [[k transform] k->transform] |
There was a problem hiding this comment.
should we do the same for transform-update-changes? instead of loop through the row map and checking if k->transform exists a transformation function for the key, we'll build out an xform from k->transform.
a plus point with that approach is we don't have to do into {}, which might gives a better performance ?
|
This will go live in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130