[flutter_tools] flutter daemon handles a closed stdout IOSink (flutte…

…r#105075)
camsim99 · Aug 10, 2022 · 5f99783 · 5f99783
1 parent e0cc609
commit 5f99783
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/flutter_tools/lib/src/daemon.dart b/packages/flutter_tools/lib/src/daemon.dart
@@ -219,6 +219,10 @@ class DaemonStreams {
       if (binary != null) {
         _outputSink.add(binary);
       }
+    } on StateError catch (error) {
+      _logger.printError('Failed to write daemon command response: $error');
+      // Failed to send, close the connection
+      _outputSink.close();
     } on IOException catch (error) {
       _logger.printError('Failed to write daemon command response: $error');
       // Failed to send, close the connection

diff --git a/packages/flutter_tools/test/general.shard/daemon_test.dart b/packages/flutter_tools/test/general.shard/daemon_test.dart
@@ -364,6 +364,20 @@ void main() {
       await daemonStreams.dispose();
       expect(outputStream.isClosed, true);
     });
+
+    testWithoutContext('handles sending to a closed sink', () async {
+      // Unless the stream is listened to, the call to .close() will never
+      // complete
+      outputStream.stream.listen((List<int> _) {});
+      await outputStream.sink.close();
+      daemonStreams.send(testCommand);
+      expect(
+        bufferLogger.errorText,
+        contains(
+          'Failed to write daemon command response: Bad state: Cannot add event after closing',
+        ),
+      );
+    });
   });
 }