Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed timer event implementations #794

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jonathanlukas
Copy link
Collaborator

Camunda Community Hub Pull Request Template

Description

This PR introduces all possible implementations for timers. This was limited before.

Additional context

closes #741

Testing your changes

An existing test was extended to assert that everything runs smooth as hell

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

Copy link

Test Results

 25 files  + 25   25 suites  +25   1m 15s ⏱️ + 1m 15s
228 tests +228  228 ✅ +228  0 💤 ±0  0 ❌ ±0 
344 runs  +344  344 ✅ +344  0 💤 ±0  0 ❌ ±0 

Results for commit a8cd3fc. ± Comparison against base commit 2ec03f6.

@jonathanlukas jonathanlukas enabled auto-merge (squash) March 13, 2024 05:28
@jonathanlukas jonathanlukas self-assigned this Mar 13, 2024
@jonathanlukas jonathanlukas merged commit 7957ecc into main Mar 13, 2024
6 checks passed
@jonathanlukas jonathanlukas deleted the bugfix/timer-event-implementations branch March 13, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant