Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): support recursive watcher repository #129

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

lzgabel
Copy link
Contributor

@lzgabel lzgabel commented Oct 25, 2021

  • support recursive watcher repository for updates

closes #94

@lzgabel
Copy link
Contributor Author

lzgabel commented Oct 25, 2021

Hi @saig0 , Can you review it? :)

@lzgabel lzgabel force-pushed the 94-lz-watch-repository branch 2 times, most recently from 3c6e4fe to 2d20d9e Compare October 26, 2021 00:17
@saig0 saig0 self-requested a review October 26, 2021 03:54
@saig0
Copy link
Contributor

saig0 commented Oct 26, 2021

@lzgabel thank you for your contribution 🎉
I'll review your PR soon 🚀

@@ -8,7 +8,7 @@ zeebe:
dmn.repository: dmn-repo

job.timeout: 10000
broker.contactPoint: 127.0.0.1:26500
broker.gateway-address: 127.0.0.1:26500

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lzgabel, shouldn't we keep contactPoint here? The maven build seems to fail because it cannot reach the Zeebe gateway. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincentgiraud , I've rebased master, try again?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all good

Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzgabel really nice work 🎉

@saig0 saig0 merged commit 48278b5 into camunda-community-hub:master Dec 14, 2021
@lzgabel lzgabel deleted the 94-lz-watch-repository branch December 14, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The worker watch the repository for updates
3 participants