Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-versions workflow fails when suggesting changes on forked PRs #3358

Open
pepopowitz opened this issue Feb 20, 2024 · 3 comments
Open

check-versions workflow fails when suggesting changes on forked PRs #3358

pepopowitz opened this issue Feb 20, 2024 · 3 comments
Assignees
@pepopowitz
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation

Comments

@pepopowitz
Copy link
Collaborator

pepopowitz commented Feb 20, 2024 •
edited
Loading

Originally noticed here.

The check-versions workflow does not have access to comment on a PR when the PR is opened from a fork. As the docs describe, we should be able to resolve this with some configuration (at the very least, by running on pull_request_target instead of pull_request....possibly also giving write permissions to the PR.).
@pepopowitz pepopowitz added kind/bug Issues related with bugs in the documentation dx Documentation infrastructure typically handled by the Camunda DX team labels Feb 20, 2024
@pepopowitz pepopowitz self-assigned this Feb 20, 2024
@pepopowitz pepopowitz mentioned this issue Feb 20, 2024
Merged
9 tasks
@pepopowitz pepopowitz mentioned this issue Feb 26, 2024
Open
@pepopowitz
Copy link
Collaborator Author

See comments in the body of #3091 for why we were unable to make this work in the original introduction of this workflow.

@pepopowitz pepopowitz moved this from 🆕 Inbox to 🏗 In Progress in Developer Experience Feb 29, 2024
@pepopowitz pepopowitz mentioned this issue Mar 1, 2024
Merged
9 tasks
@pepopowitz pepopowitz moved this from 🏗 In Progress to 👀 In Review in Developer Experience Mar 1, 2024
@pepopowitz
Copy link
Collaborator Author

Closed as fixed with #3402

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Developer Experience Mar 4, 2024
@pepopowitz pepopowitz mentioned this issue Mar 13, 2024
Merged
9 tasks
@pepopowitz
Copy link
Collaborator Author

Reopening because the fix (#3402) was reverted (in #3477). See #3477 for explanation on the revert.

@pepopowitz pepopowitz reopened this Mar 13, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🔖 Ready in Developer Experience Mar 13, 2024
@pepopowitz pepopowitz moved this from 🔖 Ready to 📋 Backlog in Developer Experience Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepopowitz pepopowitz

Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation
Projects
Developer Experience
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pepopowitz