Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3402 (check-versions running on forks) #3477

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Mar 13, 2024

Description

Reverts commit #3402.

Those changes were resulting in inaccurate, noisy comments from the check-versions workflow. Rather than listing the differences between the PR and its target branch at the time the PR was opened, it was listing the differences between the PR and its target branch right now. When the main branch had evolved since opening the PR, that meant the check-versions comment listed basically everything that had been merged since the PR was opened. Reverting this PR will put us back in a place where the check-versions workflow doesn't work for forked PRs, but it is giving accurate messages for 99% of our PRs (which are local instead of forked).

I thought I'd tested this case in #3396, but the workflow seems to be functioning differently than it was in my tests.

I'll reopen #3358 to track the need to fix the check-versions workflow for forked PRs.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz added kind/bug Issues related with bugs in the documentation dx Documentation infrastructure typically handled by the Camunda DX team labels Mar 13, 2024
@pepopowitz pepopowitz requested a review from akeller March 13, 2024 19:12
@pepopowitz pepopowitz self-assigned this Mar 13, 2024
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I know this has been a bit of a thorn this week for you, but I appreciate your flexibility here.

@pepopowitz pepopowitz merged commit 9d17f39 into main Mar 14, 2024
11 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/revert-3402-check-versions-on-forks branch March 14, 2024 14:32
theburi pushed a commit that referenced this pull request Apr 3, 2024
theburi pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants