Revert #3402 (check-versions running on forks) #3477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts commit #3402.
Those changes were resulting in inaccurate, noisy comments from the check-versions workflow. Rather than listing the differences between the PR and its target branch at the time the PR was opened, it was listing the differences between the PR and its target branch right now. When the
main
branch had evolved since opening the PR, that meant the check-versions comment listed basically everything that had been merged since the PR was opened. Reverting this PR will put us back in a place where the check-versions workflow doesn't work for forked PRs, but it is giving accurate messages for 99% of our PRs (which are local instead of forked).I thought I'd tested this case in #3396, but the workflow seems to be functioning differently than it was in my tests.
I'll reopen #3358 to track the need to fix the check-versions workflow for forked PRs.
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.