chore(deps): Update docusaurus from beta-16 to beta-17, including rewriting dark mode suppression #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akeller
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
👍
If you are interested in tackling the beast that is CSS & color theming, you can ask marketing (mainly Andy Buck) about recommendations to make dark mode with our docs a thing and add it to our backlog. I'm not anti-dark mode, I just don't think it works with our branding as-is.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1024
This PR updates docusaurus dependencies from beta-16 to beta-17. As a necessary side-quest due to feature deprecation, it rewrites our dark-mode suppression according to docusaurus's recommendation.
Proof that there's still no option to switch color modes
What it would look like if the color mode switch wasn't suppressed
In other words, what it looks like if I delete the swizzled ColorModeToggle from this PR, to show that the file is actively doing something:
Screen.Recording.2022-07-06.at.2.39.27.PM.mov