Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] test PR: suggested changes resolved #3112

Conversation

pepopowitz
Copy link
Collaborator

Description

This PR exists as a test case, and will be deleted after #3091 is completed.

Scenario: changes are suggested by the workflow, then resolved.

Expected result: A comment appears suggesting changes be ported. As the changes are resolved, the comment is updated to reflect the resolution.

When should this change go live?

Never!

@pepopowitz pepopowitz added the hold This issue is parked, do not merge. label Dec 20, 2023
@pepopowitz pepopowitz self-assigned this Dec 20, 2023
Copy link
Contributor

github-actions bot commented Dec 20, 2023

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@pepopowitz
Copy link
Collaborator Author

The initial comment on this PR:

image

@pepopowitz
Copy link
Collaborator Author

The comment after migrating one change (leaving one missing):

image

@pepopowitz
Copy link
Collaborator Author

The comment after all suggestions had been satisfied:

image

@pepopowitz
Copy link
Collaborator Author

Closing, this was for demonstration purposes only.

@pepopowitz pepopowitz closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold This issue is parked, do not merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant