Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(identity): fix identity docs #3704

Merged
merged 2 commits into from
Apr 24, 2024
Merged

docs(identity): fix identity docs #3704

merged 2 commits into from
Apr 24, 2024

Conversation

Ben-Sheppard
Copy link
Contributor

Description

Closes #3676

A couple of inconsistencies were spotted in the OIDC documentation, this PR addresses those, namely:

  1. Using the correct step reference numbers for Identity
  2. Change the client id in the issuer based URLs to correctly reflect that its the tenant ID

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@Ben-Sheppard Ben-Sheppard merged commit 2585421 into main Apr 24, 2024
9 checks passed
@Ben-Sheppard Ben-Sheppard deleted the fix-identity-docs branch April 24, 2024 16:45
theburi pushed a commit that referenced this pull request Jun 5, 2024
* docs(identity): update example to use tenant id instead of client id

* docs(identity): update confusing Identity steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:identity Issues related with Identity project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identity values in OIDC configuration use confusing step links
2 participants