-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: SAP documentation #4267
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@vobu here is a docs POC for you to think about where we can place the SAP content. |
thank you! will add on top of this PR with the SAP Integration documentation. |
@toco-cam Do you have any comments on the layout/formatting of these files? Is there any additional information you are expecting to be added with https://github.com/camunda/product-hub/issues/2415? @vobu Are you finished adding documentation to this PR? If so, I'll move this out of draft and give it a full review. |
not yet - docs for RFC connector and the BTP Integration are yet to get in there. Will be finished in cw 40 (Oct 4) the latest. Does that still give you enough time to overhaul until CCon NY? |
@vobu Sounds great! Thanks for the update. |
Hi @vobu -- just let me know when you are ready for final review here before CCon 👍 |
yes, will do as soon as I have more stuff in. Some friendly fire these days, so docs got delayed on my end. Will have finished next week Weg THE LATEST, pinky-promise-swear |
Removing |
Adding the deploy label back! Also, thanks for the status updates on this PR. |
Co-authored-by: Cole Isaac <[email protected]>
Co-authored-by: Cole Isaac <[email protected]>
Co-authored-by: Cole Isaac <[email protected]>
docs/guides/sap/odata-connector.md
Outdated
@@ -0,0 +1,170 @@ | |||
--- | |||
id: odata-connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are indeed alpha, could add these Connectors to https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/available-connectors-overview/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - but they need to be run in "hybrid" mode, on the SAP BTP of the customer. We don't run them in SaaS or on any SM k8s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself to add something on this once merged into the main PR and I can properly route to these links.
Hi all -- this is ready for a final approval to merge into the experimental structure PR, which will also get a final approval before going into |
@mesellings Looping you in for review here as most other folks are out today 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the deploy working, I've given this a skim review for anything glaring, and made a few non-blocking suggestions, but approving so it can be merged for NY, but could do with a more comprehensive review at a later date I feel 👍
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
Co-authored-by: Mark Sellings <[email protected]>
5d0b03f
into
experimental-structure-PR
🧹 Preview environment for this PR has been torn down. |
* initial 4 feature structure * adjust sidebar behavior * update overview * update sidebar * update sidebar * experimental: RPA documentation (#4440) * add rpa documentation * tidy typo * resolve comments * adjust sidebar * add to sidebar * update link * resolve comments * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/camunda-rpa-framework-library.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/experimental/rpa/rpa-integration-with-camunda.md Co-authored-by: Mark Sellings <[email protected]> --------- Co-authored-by: Mark Sellings <[email protected]> * incorporate rpa docs into sidebar * fix broken link * update img path * update image path * experimental: SAP documentation (#4267) * initial poc commit * wip: sap odata connector * wip: further docs * docs: spell check * feat: first draft of the sap docs * initial edits * revise rfc connector * remove from sidebar for now * Update docs/guides/sap/btp-integration.md Co-authored-by: Cole Isaac <[email protected]> * Update docs/guides/sap/camunda-sap-integration.md Co-authored-by: Cole Isaac <[email protected]> * Update docs/guides/sap/rfc-connector.md Co-authored-by: Cole Isaac <[email protected]> * resolve comments * second review of sap content * fix link * resolve comments * move into components for now * Update docs/components/sap/odata-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/odata-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/odata-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/rfc-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/rfc-connector.md Co-authored-by: Mark Sellings <[email protected]> * Update docs/components/sap/rfc-connector.md Co-authored-by: Mark Sellings <[email protected]> --------- Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Christina Ausley <[email protected]> Co-authored-by: christinaausley <[email protected]> Co-authored-by: Cole Isaac <[email protected]> Co-authored-by: Mark Sellings <[email protected]> * incorporate sap docs * fix broken link * minor tweak * resolve comments * typo --------- Co-authored-by: christinaausley <[email protected]> Co-authored-by: Christina Ausley <[email protected]> Co-authored-by: Mark Sellings <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Cole Isaac <[email protected]>
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).