Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing env variables for Spring SDK documentation #4447

Merged

Conversation

ana-vinogradova-camunda
Copy link
Contributor

Adding missing env variables for Spring SDK documentation

  • for REST configuration
  • for gRPC configuration

Closes: #4297

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

- for REST configuration
- for gRPC configuration
@ana-vinogradova-camunda ana-vinogradova-camunda requested a review from a team October 10, 2024 13:56

```properties
ZEEBE_GRPC_ADDRESS=http://127.0.0.1:26500/
ZEEBE_REST_ADDRESS=http://127.0.0.1:8083/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the path for Tasklist, but in the 8.5 docs I see 8080 for the Zeebe API. Can you help me understand this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akeller , thank you for pointing that out.
The examples are from my local deployment where I mapped port 8080 to 8083 for REST.
8080 would be the port for the Zeebe API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the change now.

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the discussion in the PR, but I can't test this. Given that this is an example, I think that's sufficient to merge.

@ana-vinogradova-camunda ana-vinogradova-camunda merged commit 31aa59d into main Oct 14, 2024
7 checks passed
@ana-vinogradova-camunda ana-vinogradova-camunda deleted the 4297-add-missing-spring-sdk-env-variables branch October 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add missing Environment Variables for Spring Zeebe SDK
2 participants