Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to deprecation announcement for CLI & Go #4524

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Oct 25, 2024

Description

As discussed on Slack.

I specifically did not add this to /next/.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added component:docs Documentation improvements, including new or updated content target:8.6 Issues included in the 8.6 release labels Oct 25, 2024
@akeller akeller requested review from maxdanilov and a team October 25, 2024 20:15
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.6/apis-tools/community-clients/cli-client/cli-get-started.md
  • versioned_docs/version-8.6/apis-tools/community-clients/cli-client/index.md
  • versioned_docs/version-8.6/apis-tools/community-clients/go-client/go-get-started.md
  • versioned_docs/version-8.6/apis-tools/community-clients/go-client/index.md
  • versioned_docs/version-8.6/apis-tools/community-clients/go-client/job-worker.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added "the" before "announcement" 👍

@akeller akeller merged commit 6c22402 into main Oct 28, 2024
6 checks passed
@akeller akeller deleted the add-announcement-link-86 branch October 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content target:8.6 Issues included in the 8.6 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants