-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new web modeler deploy config #4540
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@nithinssabu My instinct here was to mark the new ID field as Required in some way, as it sounds like you will be unable to deploy without it? If this is the case, it would be handy to list which other config options are required vs not, and I could add those in as well, or follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, nothing useful to add - great work! 👍 🚀 🥇
@conceptualshark If the ID field is not present or unique, then the application won't start up and the reason will be clear from the error message. In my opinion, it's fine to not have this in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
Description
Relates to https://github.com/camunda/web-modeler/issues/10571 - no changes needed; the documents on deployment pipelines/stages look compatible with the expected self managed behavior, and may only need screenshot updates when the SaaS and SM visuals are aligned
Implements to https://github.com/camunda/web-modeler/issues/10570 - added the ID field to the SM web modeler config table, and updated references to the Docker distro to include the option in Helm as well.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).