Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new web modeler deploy config #4540

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Oct 30, 2024

Description

Relates to https://github.com/camunda/web-modeler/issues/10571 - no changes needed; the documents on deployment pipelines/stages look compatible with the expected self managed behavior, and may only need screenshot updates when the SaaS and SM visuals are aligned

Implements to https://github.com/camunda/web-modeler/issues/10570 - added the ID field to the SM web modeler config table, and updated references to the Docker distro to include the option in Helm as well.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark self-assigned this Oct 30, 2024
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/components/modeler/web-modeler/play-your-process.md
  • docs/self-managed/modeler/web-modeler/configuration/configuration.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark added the 8.7.0-alpha1 November 2024 alpha release label Oct 31, 2024
@conceptualshark conceptualshark requested review from a team and nithinssabu October 31, 2024 16:49
@conceptualshark
Copy link
Contributor Author

@nithinssabu My instinct here was to mark the new ID field as Required in some way, as it sounds like you will be unable to deploy without it? If this is the case, it would be handy to list which other config options are required vs not, and I could add those in as well, or follow up.

@conceptualshark conceptualshark marked this pull request as ready for review October 31, 2024 16:51
@mesellings mesellings requested review from mesellings and removed request for a team November 1, 2024 10:49
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nothing useful to add - great work! 👍 🚀 🥇

@nithinssabu
Copy link
Contributor

@nithinssabu My instinct here was to mark the new ID field as Required in some way, as it sounds like you will be unable to deploy without it? If this is the case, it would be handy to list which other config options are required vs not, and I could add those in as well, or follow up.

@conceptualshark If the ID field is not present or unique, then the application won't start up and the reason will be clear from the error message. In my opinion, it's fine to not have this in the documentation.

Copy link
Contributor

@nithinssabu nithinssabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@nithinssabu nithinssabu merged commit d717ba7 into main Nov 3, 2024
7 checks passed
@nithinssabu nithinssabu deleted the cg-update-unified-deploy-modeler branch November 3, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7.0-alpha1 November 2024 alpha release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants