fix(menu-builder): remove new file options from tab menu

closes #4181
camunda · May 29, 2024 · 577041f · 577041f
1 parent 3f723f9
commit 577041f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/app/lib/menu/menu-builder.js b/app/lib/menu/menu-builder.js
@@ -94,13 +94,9 @@ class MenuBuilder {
     const { contextMenu } = this.options.state;
 
     if (this.options.type === 'tab') {
-      return this.appendNewFile()
+      return this.appendContextCloseTab()
         .appendSeparator()
-        .appendContextCloseTab()
-        .appendSeparator()
-        .appendContextRevealInFileExplorerTab()
-        .appendSeparator()
-        .appendOpenRecent();
+        .appendContextRevealInFileExplorerTab();
     }
 
     if (contextMenu) {

diff --git a/app/test/spec/menu/menu-builder-spec.js b/app/test/spec/menu/menu-builder-spec.js
@@ -67,6 +67,13 @@ describe('MenuBuilder', () => {
     const contextMenu = menuBuilder.buildContextMenu();
 
     expect(contextMenu).to.exist;
+    expectMenu(contextMenu, [
+      'Close Tab',
+      'Close All Tabs',
+      'Close Other Tabs',
+      undefined,
+      'Reveal in File Explorer'
+    ]);
   });
 
 
@@ -532,3 +539,9 @@ function callAction(fn, browserWindow = {}, triggeredByAccelerator = false) {
 
   return fn(null, browserWindow, { triggeredByAccelerator });
 }
+
+function expectMenu(actual, expected) {
+  const menu = actual.menu.map(item => item.label);
+
+  expect(menu).to.eql(expected);
+}