Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On quitting with unsaved files, "cancel" should prevent following prompts to save #4186

Closed
barmac opened this issue Mar 7, 2024 · 2 comments · Fixed by #4323
Closed

On quitting with unsaved files, "cancel" should prevent following prompts to save #4186

barmac opened this issue Mar 7, 2024 · 2 comments · Fixed by #4323
Assignees
@marstamm
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Milestone
M77

Comments

@barmac
Copy link
Collaborator

barmac commented Mar 7, 2024

Describe the bug

Given multiple unsaved files are opened, when I try to exit and click "cancel", prompts are displayed for each file.

Steps to reproduce

Screen.Recording.2024-03-07.at.11.37.32.mov

Expected behavior

The quitting action should be cancelled altogether and no more prompts should be displayed.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: [e.g. 2.0.0]
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response
@barmac barmac added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day labels Mar 7, 2024
@nikku
Copy link
Member

nikku commented Mar 26, 2024

Reproduced in v5.22.0.

marstamm added a commit that referenced this issue May 30, 2024
@marstamm
fix(App): stop showing dialogs after first cancel
f53a9c7 
closes #4186
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label May 30, 2024
@marstamm marstamm mentioned this issue May 30, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 30, 2024
marstamm added a commit that referenced this issue May 30, 2024
@marstamm
fix(App): stop showing dialogs after first cancel
1a0771d 
closes #4186
marstamm added a commit that referenced this issue May 30, 2024
@marstamm
fix(App): stop showing dialogs after first cancel
4c179fd 
closes #4186
@nikku
Copy link
Member

nikku commented May 30, 2024

Closed via #4323.

@nikku nikku closed this as completed May 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 30, 2024
@nikku nikku added this to the M77 milestone May 30, 2024
@nikku nikku mentioned this issue Jun 3, 2024
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
M77
Development

Successfully merging a pull request may close this issue.

fix(App): stop showing dialogs after first cancel camunda/camunda-modeler
3 participants
@nikku @marstamm @barmac