-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken BPMN diagram (incomplete DI) blows up editor #4315
Comments
This is only partially fixed via https://github.com/bpmn-io/bpmn-js/blob/develop/CHANGELOG.md#1771, a follow-up is needed. I'm investigating. |
Fixed upstream via bpmn-io/bpmn-js#2171, bpmn-io/bpmn-js#2172 and bpmn-io/bpmn-js#2180. Additional fix for |
nikku
added
fixed upstream
Requires integration of upstream change
and removed
in progress
Currently worked on
labels
May 28, 2024
nikku
added a commit
that referenced
this issue
May 30, 2024
deps: update to [email protected] Closes #4317 Closes #4315 Closes #4307
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
fixed upstream
Requires integration of upstream change
labels
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Importing missing-di-plane.bpmn.txt locally breaks the editor, even after closing a tab certain operations such as click handlers stop working; I have to forcefully reload it to restore a fully working state.
The trick for this crash is to add a diagram without a
BPMNDiagram#plane
element as an auxiliary diagram:Steps to reproduce
Expected behavior
I expect the editor to gracefully handle such a broken diagram, give me a warning, or simple ignore the diagram (silently).
Environment
Additional context
Potentially related reports: ref.
The text was updated successfully, but these errors were encountered: