Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken BPMN diagram (incomplete DI) blows up editor #4315

Closed
nikku opened this issue May 27, 2024 · 2 comments · Fixed by #4324
Closed

Broken BPMN diagram (incomplete DI) blows up editor #4315

nikku opened this issue May 27, 2024 · 2 comments · Fixed by #4324
Assignees
Labels
BPMN bug Something isn't working modeling
Milestone

Comments

@nikku
Copy link
Member

nikku commented May 27, 2024

Describe the bug

Importing missing-di-plane.bpmn.txt locally breaks the editor, even after closing a tab certain operations such as click handlers stop working; I have to forcefully reload it to restore a fully working state.

The trick for this crash is to add a diagram without a BPMNDiagram#plane element as an auxiliary diagram:

  <!-- missing plane element -->
  <bpmndi:BPMNDiagram id="BPMNDiagram_2">
  </bpmndi:BPMNDiagram>

Steps to reproduce

  1. Open missing-di-plane.bpmn.txt
  2. See that editor blows up

Expected behavior

I expect the editor to gracefully handle such a broken diagram, give me a warning, or simple ignore the diagram (silently).

Environment

  • OS: Linux
  • Camunda Modeler Version: v5.23.0
  • Execution Platform: Camunda 7, Camunda 8
  • Installed plug-ins: none

Additional context

Potentially related reports: ref.

@nikku nikku added bug Something isn't working BPMN modeling labels May 27, 2024
@nikku nikku added the in progress Currently worked on label May 28, 2024 — with bpmn-io-tasks
@nikku
Copy link
Member Author

nikku commented May 28, 2024

This is only partially fixed via https://github.com/bpmn-io/bpmn-js/blob/develop/CHANGELOG.md#1771, a follow-up is needed. I'm investigating.

@nikku nikku self-assigned this May 28, 2024
@nikku
Copy link
Member Author

nikku commented May 28, 2024

Fixed upstream via bpmn-io/bpmn-js#2171, bpmn-io/bpmn-js#2172 and bpmn-io/bpmn-js#2180.

Additional fix for no-overlapping-elements lint rule: bpmn-io/bpmnlint#135, bpmn-io/bpmnlint#136.

@nikku nikku added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels May 28, 2024
nikku added a commit that referenced this issue May 29, 2024
nikku added a commit that referenced this issue May 30, 2024
nikku added a commit that referenced this issue May 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels May 30, 2024
nikku added a commit that referenced this issue May 30, 2024
@nikku nikku closed this as completed in e526a4a May 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 30, 2024
@nikku nikku added this to the M77 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN bug Something isn't working modeling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant