Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build for arm64 on MacOS #4238

Merged
merged 1 commit into from
Apr 11, 2024
Merged

feat: build for arm64 on MacOS #4238

merged 1 commit into from
Apr 11, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Apr 11, 2024

Closes #1996
Closes #4236

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 11, 2024
@barmac
Copy link
Collaborator Author

barmac commented Apr 11, 2024

In this PR, I am also removing the custom zip code as it looks like electron builder can handle zips just fine now.

@nikku
Copy link
Member

nikku commented Apr 11, 2024

Let's include a website check as a follow-up to ensure links are not broken.

@nikku
Copy link
Member

nikku commented Apr 11, 2024

Three years after opening #1996. Time seems to be right. 🙂

@nikku nikku added this to the M76 milestone Apr 11, 2024
@nikku
Copy link
Member

nikku commented Apr 11, 2024

Let's include an update server check to verify things still work.

@barmac
Copy link
Collaborator Author

barmac commented Apr 11, 2024

Let's include an update server check to verify things still work.

The update check links to a directory with links. We don't offer a direct link to the platform-specific distribution.

@barmac
Copy link
Collaborator Author

barmac commented Apr 11, 2024

The website links will need to be updated after the release: https://camunda.com/download/modeler/

I will create an issue and add it to the release issue.

@barmac barmac merged commit 2f285e2 into develop Apr 11, 2024
18 checks passed
@barmac barmac deleted the 1996-build-for-arm branch April 11, 2024 15:05
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 11, 2024
@barmac
Copy link
Collaborator Author

barmac commented Apr 11, 2024

Follow-up: #4239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build application locally on MacOS (spawnSync zip ENOENT) I can run the App on ARM based Macs
2 participants