Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better modeler menu actions with new diagram-js #4620

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

jarekdanielak
Copy link
Contributor

@jarekdanielak jarekdanielak commented Oct 18, 2024

Related to bpmn-io/diagram-js#661

Proposed Changes

An attempt to make menu actions behavior more predictable. With new implementation of diagram-js#Canvas we can have a better understanding of what context user is working in: modeling, interacting with pop up, using properties panel etc.

Notes to self:

  • Before merging, revert package-lock.json changes.
  • Change BpmnEditor for Camunda 7.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 18, 2024
Copy link

This Pull Request targets develop branch, but contains fix commits.

Consider targeting main instead.

@jarekdanielak jarekdanielak added the enhancement New feature or request label Oct 18, 2024
@jarekdanielak
Copy link
Contributor Author

jarekdanielak commented Oct 27, 2024

Blockers:

  • Undo/Redo actions trigger twice and seem to trigger when focus is outside of canvas, despite being dependent on canvasFocused parameter.

Nice to have:

  • Edit label action can be triggered with keyboard (E) for multiple selected elements, despite being dependent on selectionLength === 1 and menu action being disabled.

@nikku nikku requested a review from lmbateman November 4, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress Currently worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants