Gracefully handle creating milestone with existing name #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This Pull Request targets Consider targeting |
nikku
reviewed
Nov 1, 2024
| TITLE: ${{github.event.milestone.title}} | ||
| run: | | ||
| MILESTONE_NUMBER=${TITLE:1} | ||
| INCREMENTED_NUMBER=$((MILESTONE_NUMBER + 1)) | ||
| echo "MILESTONE_NAME=M$INCREMENTED_NUMBER" >> $GITHUB_OUTPUT | ||
| - name: Check if Milestone already exists | ||
| id: checkIfMilestoneExists |
There was a problem hiding this comment.
Consider our discussions on steps naming in #4650 adjust your changes accordingly.
4 tasks
|
Fun fact: I thought about this approach as I reviewed your previous contribution. I ended up ditching it, as both have their merits. I do think this is cleaner and more robust though, so great to see we're taking this route now. |
nikku
approved these changes
Nov 1, 2024
nikku
force-pushed
the
1052-gracefully-handle-new-release-milestone-already-existing
branch
from
5a0d5ca
to
bf14341
Compare
misiekhardcore
force-pushed
the
1052-gracefully-handle-new-release-milestone-already-existing
branch
from
bf14341
to
d2a3444
Compare
|
I updated the naming according to our new convention and I am merging it as soon as CI passes |
misiekhardcore
deleted the
1052-gracefully-handle-new-release-milestone-already-existing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #https://github.com/bpmn-io/internal-docs/issues/1052
Proposed Changes
Check if milestone exists before trying to create it to prevent the action from exiting with an error when trying to create a milestone which already exists (e.g. https://github.com/camunda/camunda-modeler/actions/runs/11625285084/job/32375114566)
Previous approach (done in #4639 ) turned out to not work as expected in GHA environment
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}