-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy Exception List for Outbound HTTP Connectors #3252
Proxy Exception List for Outbound HTTP Connectors #3252
Comments
Decision: Go with Option 2 for now to now confuse SaaS users with this flag (as they will always go through a proxy.) |
As mentioned in the ticket's description, there are JVM/system properties for configuring a proxy, i.e.,
Customers familiar with Java are used to these properties. Since version 8.6, the HTTP connector is based on Apache HTTP Client. Since version 5, the HTTPClientBuilder uses the system properties described above if no other proxy configuration is set. |
QA informationTest Environment
Test Scope
Test DataYou will need to provide the services:
connectors:
environment:
- JAVA_OPTS=-Dhttp.proxyHost=<PROXY> -Dhttp.proxyPort=<PORT> -Dhttps.proxyHost=<PROXY> -Dhttps.proxyPort=<PORT> -Dhttp.nonProxyHosts=<OTHER_DOMAIN> Replace the variables accordingly. |
@Szik and I tested this and everything looks good to us! |
Is your feature request related to a problem? Please describe.
May companies have private and use public APIs. Private APIs must be accessed via a proxy while public ones must not. The HTTP Connectors have not option to turn the proxy on/off via configuration nor can a list of exceptions be provided.
Describe the solution you'd like
Option 1:
Add a flag to the HTTP Connectors element templates. The request will be routed to proxy if and only if the flag is set to true.
Option 2:
The Proxy can be configured via an environment variable (HTTP_PROXY_URL). Another Environment variable may be used to specify exceptions, similiar to Java's
http.nonProxyHosts
.Describe alternatives you've considered
Use the hybrid mode of the connectors to run two instances of the HTTP Connectors: One with configured Proxy, one without.
Additional context
The text was updated successfully, but these errors were encountered: