feat(proxy): Proxy exception list for outbound http connectors #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...e/src/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
Fixed
Show fixed
Hide fixed
...e/src/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
Fixed
Show fixed
Hide fixed
...e/src/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
Fixed
Show fixed
Hide fixed
...e/src/test/java/io/camunda/connector/http/base/client/apache/CustomApacheHttpClientTest.java
Fixed
Show fixed
Hide fixed
sbuettner
reviewed
Oct 7, 2024
Comment on lines
58
to
62
| new GenericContainer<>(DockerImageName.parse("sameersbn/squid:3.5.27-2")) | ||
| .withExposedPorts(3128) | ||
| .withClasspathResourceMapping("squid.conf", "/etc/squid/squid.conf", BindMode.READ_ONLY) | ||
| .waitingFor(org.testcontainers.containers.wait.strategy.Wait.forListeningPort()); | ||
| proxyContainer.start(); |
| proxy.verify(deleteRequestedFor(urlEqualTo("/path"))); | ||
| } | ||
|
|
||
| private String getWireMockBaseUrlWithPath(WireMockRuntimeInfo wmRuntimeInfo, String path) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
mathias-vandaele
approved these changes
Oct 8, 2024
johnBgood
deleted the
3252-proxy-exception-list-for-outbound-http-connectors
branch
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.6
git worktree add -d .worktree/backport-3460-to-release/8.6 origin/release/8.6
cd .worktree/backport-3460-to-release/8.6
git switch --create backport-3460-to-release/8.6
git cherry-pick -x fb03259d191c8231f2e2cf59765ace267dc25229 |
johnBgood
added a commit
that referenced
this pull request
Oct 8, 2024
* feat(rest): Use System Properties for proxy configuration * feat(rest): Use System Properties for proxy configuration * feat(rest): Lint * feat(rest): Fix imports * feat(rest): Disable proxy settings after Proxy tests * feat(rest): Extract proxy tests * feat(rest): Lint * feat(rest): Use a random port for WireMock server * feat(rest): Fix UTs * feat(rest): Fix UTs * feat(rest): Fix UTs (cherry picked from commit fb03259)
1 task
johnBgood
added a commit
that referenced
this pull request
Oct 8, 2024
#3471) * feat(rest): Use System Properties for proxy configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #3252
Checklist
no milestonelabel.