-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(download-center-upload): use gcloud storage #281
Conversation
Replace `gsutils -m cp` with `gcloud storage cp` to be working appropriately with python `>=3.12`
This PR shall replace another PR to comply with general recommendations on how to work with gcloud storage. It replaces ⚗️Verified with a draft PR in Following job steps seem to have worked just fine:
Uploaded artifacts can be found here: Nonetheless, one seemingly unrelated workflow (Build MacOS Latest) fails.
@maxdanilov Can you please review the action change itself? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM, thank you! Interesting that there's nothing akin to the -m
(parallelism) switch for gcloud storage
- is it doing that by default?
@maxdanilov
|
@barmac The initial failed run seems to be a wobbler. After a rerun the tests for macos-build succeeded. |
Replace
gsutils -m cp
withgcloud storage cp
to be working appropriately with python>=3.12
which is installed on current ubuntu runner images (>=24.04
).