Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(download-center-upload): use gcloud storage #281

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kellervater
Copy link
Member

Replace gsutils -m cp with gcloud storage cp to be working appropriately with python >=3.12 which is installed on current ubuntu runner images (>= 24.04).

Replace `gsutils -m cp` with `gcloud storage cp` to be working appropriately with python `>=3.12`
@kellervater
Copy link
Member Author

kellervater commented Oct 17, 2024

This PR shall replace another PR to comply with general recommendations on how to work with gcloud storage.

It replaces gsutil with gcloud storage.

⚗️

Verified with a draft PR in camunda-modeler.

Following job steps seem to have worked just fine:

Uploaded artifacts can be found here:

Nonetheless, one seemingly unrelated workflow (Build MacOS Latest) fails.
@barmac It seems one unit test is failing here. Can you dismiss this problem? There's obviously a single unit test failing:

Chrome Headless 129.0.0.0 (Mac OS 10.15.7) <App> #checkFileChanged should NOT update file contents on cancelling FAILED
	AssertionError: expected spy to have been called at least once, but it was never called
	    at Context.eval (webpack-internal:///1281:1853:35)

@maxdanilov Can you please review the action change itself?

Copy link
Member

@maxdanilov maxdanilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, thank you! Interesting that there's nothing akin to the -m (parallelism) switch for gcloud storage - is it doing that by default?

@kellervater
Copy link
Member Author

@maxdanilov
A bit down the documentation there's a hint in a different flag about it (Parallelism is default):

--continue-on-error, -c
If any operations are unsuccessful, the command will exit with a non-zero exit status after completing the remaining operations. This flag takes effect only in sequential execution mode (i.e. processor and thread count are set to 1). Parallelism is default.

@kellervater
Copy link
Member Author

@barmac The initial failed run seems to be a wobbler. After a rerun the tests for macos-build succeeded.
So it seems to be fine.
Will merge this one now.

@kellervater kellervater merged commit bcc8f06 into main Oct 17, 2024
3 checks passed
@kellervater kellervater deleted the gsutil-replacement branch October 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants