use npm workspace #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per folder .npmrc are deleted because npm workspace only allow a root .npmrc see npm/cli#4605
peaBerberian
reviewed
Mar 8, 2024
CLIENT.md
Outdated
|
|
||
| - Either you store it on an HTTP(S) server, in which case you'll have to | ||
| indicate its URI to the `RxPaired-inspector` (more information on that | ||
| in its directory: `./inspector`). |
There was a problem hiding this comment.
It should now be in INSPECTOR.md no?
peaBerberian
reviewed
Mar 8, 2024
CLIENT.md
Outdated
| npm install | ||
| ``` | ||
|
|
||
| You have to create a `.npmrc` file in the root directory. |
There was a problem hiding this comment.
Maybe now we'll need to add something like "if not already done", as all parts now rely on that same config file
There was a problem hiding this comment.
I added it
peaBerberian
reviewed
Mar 8, 2024
|
It's missing |
Florent-Bouisset
force-pushed
the
refactor/use-npm-workspace
branch
from
db93ec7
to
877d39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the usage of npm workspace to simplify a fix the CI and to simply the build and serve steps when developping locally.
see https://docs.npmjs.com/cli/v10/using-npm/workspaces
On this branch doing this simple commands at project root will build and serve the client, inspector and server all at once.
# in ./RxPaired npm install npm run build npm run serveWith workspace there is only one package-lock and one node_modules folder, at the root of the project.
There is now only one .npmrc at the root of the project.