Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MainSourceBufferInterface code more readable isolating inner functions #1569

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Make MainSourceBufferInterface code more readable isolating inner functions #1569

wants to merge 1 commit into from

Commits on Oct 8, 2024

  1. Make MainSourceBufferInterface code more readable isolating inner fun… 

    …ctions

The callback called on the `"updateend"` and `"error"` events on a
SourceBuffer were previously declared as arrow functions inside the
constructor.

This allowed to keep a clear JS context for the `this` keyword, but it
made the `MainSourceBufferInterface`'s constructor harder to read.

I found it more readable to declare both callback as private methods
instead, with the drawback of having to bind the `this` explictely.
    @peaBerberian
    peaBerberian committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e264f35 View commit details
    Browse the repository at this point in the history