Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug preventing Refs being serialized properly #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug preventing Refs being serialized properly #361

wants to merge 1 commit into from

Conversation

imaustink
Copy link
Contributor

Fixes #360

imaustink
imaustink commented Oct 11, 2017
View reviewed changes
can/ref/ref.js
Ref.prototype.serialize = function() {
return this[idProp];
Ref.prototype.serialize = Ref.prototype[canSymbol.for("can.serialize")] = function() {
return canReflect.serialize(this[idProp], CIDMap);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to provide a Map here? Seems to me like it would only be good for circular reference, which shouldn't happen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbmeyer justinbmeyer justinbmeyer approved these changes

@bmomberger-bitovi bmomberger-bitovi Awaiting requested review from bmomberger-bitovi

@phillipskevin phillipskevin Awaiting requested review from phillipskevin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ref isn't serializing properly
2 participants
@imaustink @justinbmeyer