fix: Fix dashboard panels not working #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dashboard panels not working by: * Replacing unavailable metrics with available ones * Adding 5 minutes instead of 1 in places where rate() is used since this requires more than one scrape data points. * Remove rate() from panel that shows total number of log messages.
orfeas-k
changed the title
ckf tag to dashboard
NohaIhab
reviewed
Apr 5, 2024
There was a problem hiding this comment.
the dashboards are functioning, but I'm struggling to interpret the Workflow operation duration and the Adds to the queue dashboards, perhaps we can improve the description and/or labels? so that it's clear what value they add.
If you think this is a stretch for this PR, I'm okay with that but we can keep it in mind as an issue
|
Discussed with @orfeas-k that redesigning the dashboards is out of scope of this task, and we'll bring up our concerns with the team to address them seperately. |
NohaIhab
approved these changes
Apr 5, 2024
orfeas-k
added a commit
that referenced
this pull request
Apr 9, 2024
* Add `ckf` tag to argo-controller's grafana dashboard.
* Fix dashboard panels not working by:
* Replacing unavailable metrics with available ones
* Change 2 minutes instead of 1 in places where rate() is used since
this requires more than one scrape data points.
* Remove rate() from panel that shows total number of log messages.
Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834
orfeas-k
added a commit
that referenced
this pull request
Apr 9, 2024
* Add `ckf` tag to argo-controller's grafana dashboard.
* Fix dashboard panels not working by:
* Replacing unavailable metrics with available ones
* Change 2 minutes instead of 1 in places where rate() is used since
this requires more than one scrape data points.
* Remove rate() from panel that shows total number of log messages.
Ref canonical/bundle-kubeflow#856
Ref canonical/bundle-kubeflow#834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ckftag to argo-controller's grafana dashboard.this requires more than one scrape data points.
Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834