Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on pull request and on push workflows #17

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Mar 25, 2024

closes #16

NOTE this PR's CI will fail until all rockcraft projects in this repo have the following:

An up to date rockcraft file with the latest supported format (i.e. base and version must be valid)
Each rockcraft project directory must have a tox.ini file with envlist = pack, export-to-docker, sanity, integration. Example here.
Each rockcraft project directory must have a tests/ directory with sanity tests inside. Example here.

@NohaIhab NohaIhab requested a review from a team as a code owner March 25, 2024 15:41
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Like mentioned here in the note to reviewer, the existing rocks here will no longer build once this is implemented. This is the change requested by #16 though so lgtm.

I'll raise whether we need to do more work on this in the next daily

@NohaIhab
Copy link
Contributor Author

thanks @ca-scribner
I made that clear in the PR descirption

@NohaIhab NohaIhab merged commit d736a20 into main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argo-workflow-rocks: Update push and pull_request CI
2 participants