-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosl
to requirements.in
, remove juju_topology
, when bumping prometheus-scrape charm lib to revision 40
#849
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5467.
|
In that PR, my understanding is that the following comment is wrong and cosl comes from prometheus scrape as the issue describes
Also, bumping requirements should happen with
(same for unit) |
cosl
to requirements.in
, remove juju_copology
, when bumping prometheus-scrape charm lib to revision 40cosl
to requirements.in
, remove juju_topology
, when bumping prometheus-scrape charm lib to revision 40
We can use this as a reference for instructions when we need to update more charms' libraries but closing it, since it doesn't serve any purpose being open. |
switch to jlumbroso/free-disk-space for freeing runner space (#428) The previous space freeing method (easimon/maximize-build-space) at some point circa 2024-01 stopped freeing as much space, likely due to changes in the runner (~29GB free after it freed space). Not sure why this happened, but jlumbroso/free-disk-space at time of this commit would get us up to ~45GB free on the runner without negative effects so we've switched to that. Support functionality to override default images for kfp-profile-controller (#416) * Support functionality to override default images for kfp-profile-controller ci: remove destructive mode from integration tests (#441) The charmcraft issues that forced us to use destructive mode are now fixed. build: install `jinja2` from binary (#443) This commit installs jinja2 (an install dependency of charmed-kubeflow-chisme) as a binary to avoid running into the build time issues described in canonical/bundle-kubeflow#883. Part of canonical/bundle-kubeflow#883 refactor: use k8s_service_info lib instead of SDI (#436) * refactor: use k8s_service_info lib instead of SDI Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon. This commit also ensures that mlmd runs with trust=True in the integration tests. Fixes #413 fix: Pin integration test dependencies in main (#434) * pin integration test dependencies Co-authored-by: Daniela Plascencia <[email protected]> feat: Integrate ROCK in metadata-writer charm (#439) chore: Bump o11y libs and remove obsolete juju topology (#446) Ref canonical/bundle-kubeflow#880 Ref canonical/bundle-kubeflow#849 ci: bump juju to 3.5
Context
the prometheus-scrape charm lib added a requirement for the
cosl
package to be installed by the charm. When we bump the library, we need to add this package otherwise the charm will be inoperable.What needs to get done
here is an example of the changes required. Steps to fix this are:
Definition of Done
When all charms we have are using the updated libs. This likely will occur during the 1.9 release cycle
The text was updated successfully, but these errors were encountered: