fix(templates): replace flake8 and pydocstyle with ruff #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/1461/CRAFT-2371/ruff
branch
from
b11d853
to
5ed77fa
Compare
lengau
force-pushed
the
work/1461/CRAFT-2371/ruff
branch
from
5ed77fa
to
fa3a7a6
Compare
mr-cal
approved these changes
Oct 8, 2024
sergiusens
reviewed
Oct 10, 2024
sergiusens
reviewed
Oct 10, 2024
dariuszd21
approved these changes
Oct 10, 2024
| @@ -18,7 +18,6 @@ cryptography==43.0.1 | |||
| dill==0.3.9 | |||
| distro==1.9.0 | |||
| docker==7.1.0 | |||
| flake8==7.1.1 | |||
There was a problem hiding this comment.
Those are flake8 install_requirements, are other tools still rely on them if you delete it ?
mccabe>=0.7.0,<0.8.0
pycodestyle>=2.12.0,<2.13.0
pyflakes>=3.2.0,<3.3.0
There was a problem hiding this comment.
Not entirely sure, but once I merge in some uv-based changes those will be automatically recalculated.
Comment on lines
+1
to
+2
| # Copyright {{ year }} {{ author }} | ||
| # See LICENSE file for licensing details. |
There was a problem hiding this comment.
Shouldn't be worth to move this tox configuration to the pyproject.toml as you require 4.0.0 minimal version anyway?
https://tox.wiki/en/latest/config.html#pyproject-toml-native
There was a problem hiding this comment.
Possibly, but out of scope as this is just copying the tox files from the other templates.
lengau
force-pushed
the
work/1461/CRAFT-2371/ruff
branch
from
0dc20bf
to
4079119
Compare
sergiusens
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1461