Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force tox numpy version workaroud np 2.0 (infra) #1296

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jun 17, 2024

Description

The current version of opencv doesn't support the latest version of numpy but doesn't enforce the version of numpy to be installed, therefore pulling latest. This hardcodes the version waiting for this to be fixed.

Resolved issues

N/A

Documentation

N/A

Tests

This is a tox change, this is the test.

Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1!

@fernando79513 fernando79513 merged commit a3d982d into main Jun 17, 2024
9 checks passed
@fernando79513 fernando79513 deleted the hardcode_np_dependency branch June 17, 2024 09:55
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.10%. Comparing base (397306c) to head (a0e9f03).
Report is 124 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   44.10%   44.10%           
=======================================
  Files         358      358           
  Lines       38765    38765           
  Branches     6571     6571           
=======================================
  Hits        17096    17096           
  Misses      21006    21006           
  Partials      663      663           
Flag Coverage Δ
provider-base 18.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants