-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(20.04) add slice for crun and uidmap #223
feat(20.04) add slice for crun and uidmap #223
Conversation
Diff of dependencies: |
8a539fa
to
2540b89
Compare
2540b89
to
3ecc0e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are some issues regarding the linting (see workflow runs) to be fixed, and it is suggested to add the copyright files explicitly in the slice definitions.
e408b20
to
d9b7d0f
Compare
@cjdcordeiro @rebornplusplus can you approve the workflow please? |
add copyright slice
essential sort
3581c70
to
fd713fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the copyright files for libcap2
and libzstd1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added the crun
test here. LGTM. Thanks @endersonmaia
P.S. couldn't find a proper case to test @endersonmaia if you have a testable scenario I'd be take to take it in! |
@cjdcordeiro by head, I think you could install crun and uidmap and create a container from a bundle (busybox?) and try to run with an unprivileged user. AFAIK, when running a container with crun using an unprivileged user, it will require uidmap to work. I may give it a try later, no promises 😅 |
That would be really useful :) thanks |
Proposed changes
This PR will add crun and uidmap slices to Ubuntu 20.04 release
Forward porting
Testing
Checklist
Additional Context