Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(20.04): add 'copyright' slice to all SDFs #231

Merged

Conversation

cjdcordeiro
Copy link
Collaborator

Proposed changes

Same as #228

Forward porting

#228
#229
#230

Checklist

Additional Context

Copy link

github-actions bot commented May 1, 2024

Diff of dependencies:

slices/base-files.yaml
@@ -1,3 +0,0 @@
-awk
-libc6
-libcrypt1
slices/base-passwd.yaml
@@ -1,2 +0,0 @@
-libc6
-libdebconfclient0
slices/bash.yaml
@@ -1,4 +1,2 @@
-base-files
-debianutils
 libc6
 libtinfo6
slices/ca-certificates-java.yaml
@@ -1,4 +1,2 @@
 ca-certificates
-default-jre-headless
-java8-runtime-headless
 libnss3
slices/ca-certificates.yaml
@@ -1,3 +0,0 @@
-debconf
-debconf-2.0
-openssl
slices/dash.yaml
@@ -1,5 +1 @@
-debconf
-debconf-2.0
-debianutils
-dpkg
 libc6
slices/fontconfig-config.yaml
@@ -1,5 +1 @@
 fonts-dejavu-core
-fonts-freefont
-fonts-liberation
-ttf-bitstream-vera
-ucf
slices/libc-bin.yaml
@@ -1 +0,0 @@
-libc6
slices/libc6.yaml
@@ -1,2 +0,0 @@
-libcrypt1
-libgcc-s1
slices/libfreetype6.yaml
@@ -1,3 +1,4 @@
+libbrotli1
 libc6
 libpng16-16
 zlib1g
slices/libpng16-16.yaml
@@ -1,2 +1 @@
 libc6
-zlib1g
slices/libssl1.1.yaml
@@ -1,3 +1 @@
-debconf
-debconf-2.0
 libc6
slices/openjdk-8-jre-headless.yaml
@@ -1,20 +1,10 @@
 ca-certificates-java
-java-common
 libc6
-libcups2
 libfontconfig1
 libfreetype6
 libgcc-s1
 libjpeg-turbo8
-libjpeg8
 liblcms2-2
-libnss3
 libpcsclite1
 libstdc++6
-libx11-6
-libxext6
-libxi6
-libxrender1
-libxtst6
-util-linux
 zlib1g
slices/readline-common.yaml
@@ -1,2 +0,0 @@
-dpkg
-install-info

@cjdcordeiro cjdcordeiro force-pushed the focal/add-copyright-dependency branch from 761902e to fbd9f71 Compare May 1, 2024 10:30
@cjdcordeiro cjdcordeiro self-assigned this May 1, 2024
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The packages who have copyright files within them, do have the copyright slices added in this PR.

The files who do not have the copyright files for this release are the following:

  • libgcc-s1
  • libncursesw6
  • libpython3.8-stdlib
  • libstdc++6

I only left a nit comment about spacing inside the slice definition files. But please feel free to ignore that -- it's a nitpick.

slices/liblzma5.yaml Show resolved Hide resolved
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cjdcordeiro cjdcordeiro merged commit 9d74558 into canonical:ubuntu-20.04 May 3, 2024
12 checks passed
@cjdcordeiro cjdcordeiro deleted the focal/add-copyright-dependency branch May 3, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants