Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add libcrypto++8t64 slice #242

Merged

Conversation

endersonmaia
Copy link

@endersonmaia endersonmaia commented May 10, 2024

Proposed changes

Add libcrypto++8t64 to 24.04

Related issues/PRs

/closes #241

Checklist

Copy link

Diff of dependencies:
None found.


@endersonmaia
Copy link
Author

I'm not sure how to provide testing instructions for a lib slice?

Maybe provide an output for the ldd ? Any guidance is appreciated.

@rebornplusplus rebornplusplus self-assigned this May 16, 2024
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@rebornplusplus rebornplusplus removed their assignment May 16, 2024
@cjdcordeiro cjdcordeiro self-assigned this May 16, 2024
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cjdcordeiro
Copy link
Collaborator

I'm not sure how to provide testing instructions for a lib slice?

Maybe provide an output for the ldd ? Any guidance is appreciated.

as this is a library, and a simple one, this might indeed be a bit tricky. We will in the coming months come up with a more well-defined structure for functional testing.

Until then, this PR is simple enough to get merged. Thanks ;)

@cjdcordeiro cjdcordeiro merged commit af8fbe1 into canonical:ubuntu-24.04 May 16, 2024
12 checks passed
@endersonmaia endersonmaia deleted the 24.04/add-libcrypto++8 branch May 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants