-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add libcrypto++8t64 slice #242
feat(24.04): add libcrypto++8t64 slice #242
Conversation
Diff of dependencies: |
I'm not sure how to provide testing instructions for a lib slice? Maybe provide an output for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
as this is a library, and a simple one, this might indeed be a bit tricky. We will in the coming months come up with a more well-defined structure for functional testing. Until then, this PR is simple enough to get merged. Thanks ;) |
Proposed changes
Add libcrypto++8t64 to 24.04
Related issues/PRs
/closes #241
Checklist