feat(24.04): systemd and dependencies

[Meulengracht]

Proposed changes

Add systemd slice and it's dependencies

Testing

Smoke testing mount

mkdir mount-root
chisel cut --root mount-root bash_bins coreutils_bins passwd_config base-files_base mount_bins
sudo chroot mount-root/
mkdir /proc
mount -t proc proc /proc
umount /proc

Smoke testing systemd

mkdir systemd-root
chisel cut --root systemd-root bash_bins coreutils_bins passwd_config base-files_base systemd_bins
sudo chroot systemd-root
mkdir /proc
mount -t proc proc /proc
systemctl enable [email protected]
systemctl disable [email protected]
systemctl preset-all
systemd --help
journalctl --update-catalog
umount /proc

Checklist

• I have read the contributing guidelines
• I have already submitted the CLA form

[github-actions]

Diff of dependencies:
None found.

---

[cjdcordeiro]

thanks.

the checks are failing (systemd related I believe).

I also couldn't make the mount_bins slice work...can you provide a test case for that?

[Meulengracht]

thanks.

the checks are failing (systemd related I believe).

I also couldn't make the mount_bins slice work...can you provide a test case for that?

I updated the description in the PR with a testing case

[cjdcordeiro]

Thanks. could you please put that into an integration test?

[zhijie-yang]

LGTM. One thing worth noticing: adding the --cap-add SYS_ADMIN and --security-opt apparmor=confined would make the test runner vulnerable to malicious test cases. We must carefully review the spread tests from external contributors before we let them run.

[rebornplusplus]

Very nice slices! Nice tests too!

I left a few comments below -- mostly about the systemd slices, with a few nitpicks here and there. Please let me know what you think about those.

[Meulengracht]

@rebornplusplus this PR is ready for review

[rebornplusplus]

Looks good to me overall. Only left a few nitpicks and questions.

Splendid job slicing the systemd package! (Other packages too) Took me a long while to review those systemd slices, I wonder what it must have taken you to write them in the first place.

[Meulengracht]

@rebornplusplus @cjdcordeiro tests are now running with rebased on master with the lxd backend, the tests are restored, can we give this a review again?

[rebornplusplus]

Looks good to me, thank you very much!

Let's settle on the nice.conf file in that thread however, before merging.

[Meulengracht]

Looks good to me, thank you very much!

Let's settle on the nice.conf file in that thread however, before merging.

I found the file and added it in my last commit! Thanks for the reviews!

It seems the file may have been moved.

EDIT: added the correct path :-)